rdblue commented on pull request #3269:
URL: https://github.com/apache/iceberg/pull/3269#issuecomment-962005947
> one more thing to consider on your PR is how to update
SupportsCatalogOptions to be able to pass the time travel information.
I was thinking about this a bit more and I think that the read options are
still passed through. All we should need to do is to standardize the time
travel property names and pass the values to the new `loadTable` method.
Something like this:
* User calls `spark.read.format("iceberg").option("version",
123245).load("db.table")`
* Spark uses `SupportsCatalogOptions` to get `(catalog, Identifier.of("db",
"table"))`
* Spark extracts `version` from the read options and calls
`catalog.loadTable(ident, version)`
I think that should work. What do you think, @huaxingao?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
