wypoon commented on pull request #3269: URL: https://github.com/apache/iceberg/pull/3269#issuecomment-962270388
@rdblue @huaxingao I agree with your core suggestion: - Overload `TableCatalog#loadTable` with variants that take a version (String) or a timestamp (long, millis since the Unix epoch) parameter. Then standardize names of options that correspond to VERSION AS OF and TIMESTAMP AS OF, and if one of them is set, call the appropriate`TableCatalog#loadTable`. May I suggest "as-of-version" and "as-of-timestamp" for the options? We already use "as-of-timestamp" in Iceberg. (Side note: In Iceberg documentation, the "as-of-timestamp" option is shown being used with a String rather than a long value, but we actually use the value as a long.) I support being able to use a tag instead of the snapshot-id for the value of VERSION AS OF. But I'm less convinced of the value of being able to use a branch. Perhaps it is enough to support using the branch as part of the table identifier (whether delimited by `.` or another symbol)? It would be nice to support specifying the branch in SQL using something like IN BRANCH as @jackye1995 suggested (and @pvary finds acceptable); correct me if I'm wrong, but is the problem then that it will be opposed if it is not in Delta Lake? An orthogonal question for @huaxingao: is it possible to have FOR SYSTEM_TIME AS OF as a synonym for TIMESTAMP AS OF and FOR SYSTEM_VERSION AS OF as a synonym for VERSION AS OF in Spark SQL? While they are not what is used in Delta Lake, I'm just suggesting them as synonyms. This would allow compatibility with Hive and Impala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
