xinbinhuang commented on pull request #3059: URL: https://github.com/apache/iceberg/pull/3059#issuecomment-962293037
> Looks good to me, I only had a minor question about whether we should test v1 tables who have had spec columns added and then removed but I think this isn't strictly necessary. @RussellSpitzer Sorry for taking this long. I've added the test to check unpartitioned spec after removing all columns. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
