rdblue commented on a change in pull request #3400:
URL: https://github.com/apache/iceberg/pull/3400#discussion_r744288956
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java
##########
@@ -131,6 +131,12 @@ public int orcBatchSize() {
.parse();
}
+ public Long splitSizeOption() {
Review comment:
Ah, nevermind. I see that the other `splitSize` method merges in the
table settings. I think that's fine for now, but in a follow-up we should start
building the Iceberg `TableScan` in the scan builder and passing it in. Then we
could use the new `TableScan` methods everywhere instead of relying on
`SparkReadConf` to duplicate logic to produce those settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
