rdblue commented on a change in pull request #3492:
URL: https://github.com/apache/iceberg/pull/3492#discussion_r744296636
##########
File path: core/src/main/java/org/apache/iceberg/io/RollingDataWriter.java
##########
@@ -41,7 +41,6 @@ public RollingDataWriter(FileWriterFactory<T> writerFactory,
OutputFileFactory f
super(fileFactory, io, targetFileSizeInBytes, spec, partition);
this.writerFactory = writerFactory;
this.dataFiles = Lists.newArrayList();
- openCurrentWriter();
Review comment:
`openCurrentWriter` calls `newWriter`, which is implemented by
subclasses. In this case, it uses `writerFactory`. Calling `openCurrentWriter`
in the parent class will cause `newWriter` to be called before setting
`writerFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
