rdblue commented on pull request #3454: URL: https://github.com/apache/iceberg/pull/3454#issuecomment-962681328
@jackye1995, thanks for getting this done! Sorry I didn't have a chance to review it sooner. My only comment is that I don't think that we are using "min" in a consistent way so the option names may be confusing. For file sizes, min and max are the min and max _allowed_ file sizes. Anything that is larger than max or less than min gets rewritten. But min deletes per file is actually the minimum before taking action. In other words, it is the _maximum allowed_ number of delete files. I'd prefer making these consistent and using `max-delete-files` instead of `min-deletes-per-file`. That fixes the min/max issue and also is more clear that we are talking about delete files and not actual deletes in the files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
