openinx commented on a change in pull request #3477:
URL: https://github.com/apache/iceberg/pull/3477#discussion_r744576384
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/data/FlinkAvroReader.java
##########
@@ -63,6 +65,13 @@ public RowData read(RowData reuse, Decoder decoder) throws
IOException {
return DecoderResolver.resolveAndRead(decoder, readSchema, fileSchema,
reader, reuse);
}
+ @Override
+ public void setRowPositionSupplier(Supplier<Long> posSupplier) {
Review comment:
I think it's a critical bug which we've missed to set the `posSupplier`
to the `reader` since https://github.com/apache/iceberg/pull/1222. But I'm
still not sure why this
[TestFlinkInputFormatReaderDeletes](https://github.com/apache/iceberg/blob/1d8164383baf0e343ade13b21ed0e4d4d02c56cd/flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormatReaderDeletes.java)
did not cover the avro case.
Let me dig it into deeper and try to provide unit tests in the
`TestFlinkInputFormatReaderDeletes` to address this thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
