kbendick commented on pull request #3500: URL: https://github.com/apache/iceberg/pull/3500#issuecomment-963907331
> > This is a good catch. Thank you @kevinjqliu! > > cc @nastra who authored this action. Do you have the need to be able to run this action in your fork (where editing this out and pushing it into your fork's master branch wouldn't be a viable work around)? > > EDIT: Also, this might be somewhat urgent if somebody's fork _does_ have permissions (which would be surprising but you never know). > > @kbendick no I don't need to have this enabled in my own fork, so let's get this merged. @kevinjqliu thanks for bringing this up. Agreed let’s get this merged ASAP. Feel free to ask @rymurr to merge this since y’all are up. If he’s not available. I’m OOO for much of the day tomorrow but I’ll ask somebody in me timezone otherwise. This seems pretty important. We should also consider locking down the permissions of this particular job (and eventually all of them). Take a look at the labeler workflow that I added permissions to a while back @nastra. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
