openinx commented on a change in pull request #3504:
URL: https://github.com/apache/iceberg/pull/3504#discussion_r745484462
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -242,6 +242,6 @@ private TableProperties() {
public static final String MERGE_CARDINALITY_CHECK_ENABLED =
"write.merge.cardinality-check.enabled";
public static final boolean MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT = true;
- public static final String UPSERT_MODE_ENABLE = "write.upsert.enable";
- public static final boolean UPSERT_MODE_ENABLE_DEFAULT = false;
+ public static final String UPSERT_ENABLED = "write.upsert.enabled";
Review comment:
We don't have any released version since the PR got merged:
https://github.com/apache/iceberg/pull/2863. I think it's OK to rename it to
`enabled`.
I think it's my mistake because I did not notice that all the iceberg switch
are named as `xxx.enabled` before. Thanks for the fix before we have a
release, so that we don't have to maintain this inconsistent name for at least
one release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
