rdblue commented on a change in pull request #3505:
URL: https://github.com/apache/iceberg/pull/3505#discussion_r745872767
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkMergeScan.java
##########
@@ -72,7 +69,7 @@
this.splitLookback = readConf.splitLookback();
this.splitOpenFileCost = readConf.splitOpenFileCost();
-
Preconditions.checkArgument(!options.containsKey(SparkReadOptions.SNAPSHOT_ID),
"Can't set snapshot-id in options");
+ Preconditions.checkArgument(readConf.snapshotId() == null, "Can't set
snapshot-id in options");
Review comment:
I think this is starting to conflict with the changes that build a
`TableScan` in the scan builder and pass that into the scan implementations. We
should probably do that refactor sooner rather than later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
