aokolnychyi commented on a change in pull request #3516:
URL: https://github.com/apache/iceberg/pull/3516#discussion_r746266639
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchScan.java
##########
@@ -130,83 +122,6 @@ public StructType readSchema() {
return readSchema;
}
- @Override
- public InputPartition[] planInputPartitions() {
- String expectedSchemaString = SchemaParser.toJson(expectedSchema);
-
- // broadcast the table metadata as input partitions will be sent to
executors
- Broadcast<Table> tableBroadcast =
sparkContext.broadcast(SerializableTable.copyOf(table));
-
- List<CombinedScanTask> scanTasks = tasks();
- InputPartition[] readTasks = new InputPartition[scanTasks.size()];
-
- Tasks.range(readTasks.length)
- .stopOnFailure()
- .executeWith(localityPreferred ? ThreadPools.getWorkerPool() : null)
- .run(index -> readTasks[index] = new ReadTask(
- scanTasks.get(index), tableBroadcast, expectedSchemaString,
- caseSensitive, localityPreferred));
-
- return readTasks;
- }
-
- @Override
- public PartitionReaderFactory createReaderFactory() {
Review comment:
I think this method got bigger and bigger over time and was fairly
complicated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
