jun-he commented on issue #3464:
URL: https://github.com/apache/iceberg/issues/3464#issuecomment-964845364


   @CircArgs This is an interesting idea. IIUC, we actually buffer the 
FixedType and will 
   ```FixedType[16](string.encode("foo")) and 
FixedType[16](string.encode("bar")) ``` write to the same object's `value: 
bytes` field?
   
   @samredai yep, `isinstance(type_2, BooleanType)  # False` is false as 
BooleanType is actually an instance and ``isinstance(type_2, Type) ` will be 
true. 
   
   In the transforms PR(https://github.com/apache/iceberg/pull/3450), I have to 
deal with them separately, which is less ideal. Hope we can find a viable path 
to unify them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to