jun-he edited a comment on issue #3464:
URL: https://github.com/apache/iceberg/issues/3464#issuecomment-964845364
@CircArgs This is an interesting idea. IIUC, we actually create a FixedType
class for every new length and
```FixedType[16](string.encode("foo")) and
FixedType[17](string.encode("bar")) ``` be the instances of the different
`_FixedType` (but same `__name__`).
But still trying to see how the consolidation helps here, e.g. transform,
which expects to get a `type` instead of `type+literal`. Also, many places
calls method from types, which will then become class methods in the
consolidated class?
@samredai yep, `isinstance(type_2, BooleanType) # False` is false as
BooleanType is actually an instance and ``isinstance(type_2, Type) ` will be
true.
In the transforms PR(https://github.com/apache/iceberg/pull/3450), I have to
deal with them separately, which is less ideal. Hope we can find a viable path
to unify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
