RussellSpitzer commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r747739317
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/NullabilityHolder.java
##########
@@ -75,6 +77,7 @@ public int numNulls() {
}
public void reset() {
+ // TODO: do we have reset the values too?
Review comment:
Again I think the assumption of this class is that you never call a
"set" method more than once on an index and that you call it on every index.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/NullabilityHolder.java
##########
@@ -52,10 +52,12 @@ public void setNotNull(int index) {
}
public void setNulls(int startIndex, int num) {
+ // TODO: do we have to modify numNulls?
System.arraycopy(nulls, 0, isNull, startIndex, num);
}
public void setNotNulls(int startIndex, int num) {
+ // TODO: do we have to modify numNulls?
Review comment:
Unless we were unsetting a value that was previously set as null I don't
think we would change things here. This api basically requires you to only call
"set" on an index a single time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
