RussellSpitzer commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r748451956
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/NullabilityHolder.java
##########
@@ -52,10 +52,12 @@ public void setNotNull(int index) {
}
public void setNulls(int startIndex, int num) {
+ // TODO: do we have to modify numNulls?
Review comment:
We currently just assume the caller is carful, I think we can just keep
that assumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
