kbendick commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r748673281
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -30,6 +30,14 @@ private CatalogProperties() {
public static final String FILE_IO_IMPL = "io-impl";
public static final String WAREHOUSE_LOCATION = "warehouse";
+ public static final String TABLE_CACHE_ENABLED = "cache-enabled";
+ public static final boolean TABLE_CACHE_ENABLED_DEFAULT = true;
+ public static final String TABLE_CACHE_EXPIRATION_ENABLED =
"cache.expiration-enabled";
Review comment:
Sure that makes sense to me. Since it's a new catalog level config, the
fewer options users have to set to get the same behavior, the better in my view.
One concern is that users will then have to specifically choose a timeout
value. Feedback I've received offline so far has mentioned that people aren't
too sure what value would be best to use. Removing the `ENABLED` option makes
it harder to have a default and remove the need to make that choice.
But I guess if we always set up the examples with the "default" value, users
will likely copy that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
