rdblue commented on a change in pull request #3548:
URL: https://github.com/apache/iceberg/pull/3548#discussion_r748891511



##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -222,11 +222,11 @@ public SparkTable alterTable(Identifier ident, 
TableChange... changes) throws No
     try {
       Table table = load(ident);
       commitChanges(table, setLocation, setSnapshotId, pickSnapshotId, 
propertyChanges, schemaChanges);
+      table.refresh();
+      return new SparkTable(table, false);

Review comment:
       Please add a comment to explain the boolean argument here.

##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -222,11 +222,11 @@ public SparkTable alterTable(Identifier ident, 
TableChange... changes) throws No
     try {
       Table table = load(ident);
       commitChanges(table, setLocation, setSnapshotId, pickSnapshotId, 
propertyChanges, schemaChanges);
+      table.refresh();
+      return new SparkTable(table, false);

Review comment:
       Please add an inline comment to explain the boolean argument here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to