kbendick commented on a change in pull request #3552:
URL: https://github.com/apache/iceberg/pull/3552#discussion_r749761093
##########
File path:
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/RowDataWrapper.java
##########
@@ -80,7 +81,7 @@ public int size() {
throw new UnsupportedOperationException("Could not set a field in the
RowDataWrapper because rowData is read-only");
}
- private interface PositionalGetter<T> {
+ private interface PositionalGetter<T> extends Serializable {
Review comment:
If these are going to extend serializable, do we need `serialVersionUID`
somewhere?
Specifically for Flink, if any of implementations of this interface get
persisted as state, will users have to lose state if they remove operators from
their job graph? If they're not part of state, I suppose it's not mandatory for
implementing classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
