ArtfulCoder commented on a change in pull request #3207:
URL: https://github.com/apache/iceberg/pull/3207#discussion_r749786174
##########
File path: core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java
##########
@@ -36,12 +38,34 @@
public class RewriteFileGroup {
private final FileGroupInfo info;
private final List<FileScanTask> fileScanTasks;
+ private final Set<DeleteFile> removedDeletes;
private Set<DataFile> addedFiles = Collections.emptySet();
- public RewriteFileGroup(FileGroupInfo info, List<FileScanTask>
fileScanTasks) {
+ public RewriteFileGroup(FileGroupInfo info, List<FileScanTask> fileScanTasks,
+ boolean removePartitionDeletes, boolean
removeGlobalDeletes) {
this.info = info;
this.fileScanTasks = fileScanTasks;
+ this.removedDeletes = Sets.newHashSet();
+ for (FileScanTask task : fileScanTasks) {
+ if (task.spec().isUnpartitioned()) {
+ if (removePartitionDeletes) {
Review comment:
If the task.spec().isUnpartitioned() == true, should we handle
globalDelete files as well..
from the code, it seems that only the partitionDelete files are considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
