ajantha-bhat commented on pull request #3469: URL: https://github.com/apache/iceberg/pull/3469#issuecomment-969879040
> This looks fine to me, my only question would be should we be removing all the tests for the deprecated pathway before we remove that code from the codebase. Since the deprecated functions call the new ones it seems like we would be ok keeping them that way? I don't have a strong opinion here though. @aokolnychyi what do you think? code is anyways deprecated. So, I felt it is ok to remove testcase. Also spark actions don't have testcase. I wanted to run some testcase and I found testcase doesn't exist. So, I added this PR. I am even ok to keep deprecated test class and add new test class. But that shows lot of code in diff. Hence I went with this method. waiting for @aokolnychyi 's comments on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
