RussellSpitzer commented on a change in pull request #3517:
URL: https://github.com/apache/iceberg/pull/3517#discussion_r750715460
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java
##########
@@ -205,6 +205,11 @@ private boolean shouldProcess(Snapshot snapshot) {
"Cannot process delete snapshot : %s. Set read option %s to allow
skipping snapshots of type delete",
snapshot.snapshotId(),
SparkReadOptions.STREAMING_SKIP_DELETE_SNAPSHOTS);
return false;
+ case DataOperations.OVERWRITE:
+ Preconditions.checkState(skipDelete,
+ "Cannot process overwrite snapshot : %s. Set read option %s to
allow skipping snapshots of type overwrite",
+ snapshot.snapshotId(),
SparkReadOptions.STREAMING_SKIP_DELETE_SNAPSHOTS);
+ return false;
default:
Review comment:
Should add a test for this new conf option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
