zhengzengprc commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r750724524
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
##########
@@ -247,6 +249,46 @@ public void
testReadingStreamFromTimestampStartWithExistingTimestamp() throws Ex
Assertions.assertThat(actual).containsExactlyInAnyOrderElementsOf(Iterables.concat(expected));
}
+ @SuppressWarnings("unchecked")
+ @Test
+ @Ignore("Existing logic doesn't work when the expired snapshot gets deleted")
Review comment:
Hello @RussellSpitzer ,
Thanks for reviewing. This test tries to reproduce the problem @rdblue
mentioned above, while some snapshot expired, the the "parent" will break in
some point with NPE since the snapshot is not available anymore. And I don't
find a good way to address this problem yet, so created the unit test for
reproducible purpose. The PR is still in progressing, once the logic is settled
down this test will either remove or removing the Ignore tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
