rdblue commented on a change in pull request #3556:
URL: https://github.com/apache/iceberg/pull/3556#discussion_r750734826
##########
File path: site/docs/spec.md
##########
@@ -212,6 +212,24 @@ Columns in Iceberg data files are selected by field id.
The table schema's colum
For example, a file may be written with schema `1: a int, 2: b string, 3: c
double` and read using projection schema `3: measurement, 2: name, 4: a`. This
must select file columns `c` (renamed to `measurement`), `b` (now called
`name`), and a column of `null` values called `a`; in that order.
+Tables may also define a property `schema.name-mapping.default` with a JSON
`name mapping` containing a list of `field mapping` objects. These mappings
provide fallback field ids to be used when a data file does not contain field
id information. Each object should contain
+
+* `names`: A required list of 0 or more names for a field.
+* `field-id`: An optional Iceberg field ID used when a field's name is present
in `names`
+* `fields`: An optional list of field mappings for child field of structs,
maps, and lists.
+
+Field mapping fields are constrained by the following rules
+
+* A name may contain `.` but this refers to a literal name, not a nested
field. For example, `a.b` refers to a field named `a.b`, not child field `b` of
field `a`.
+* Each child field should be defined with their own `field-mapping` under
`fields`. Multiple values for `names` may be mapped to a single field ID to
support cases where a field may have different names in different data files.
Review comment:
Why is it `field-mapping` rather than "field mapping"? Shouldn't it be
"Each child field should be defined with its own field mapping under `fields`".
Also, I think it makes sense to combine the "Each child field..." part with
the first bullet because it explains how nesting works, not just names. Maybe
it makes sense to everyone else this way though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]