ajantha-bhat commented on pull request #3375: URL: https://github.com/apache/iceberg/pull/3375#issuecomment-971517807
@rymurr , @RussellSpitzer : a) I added few test cases to sparkExpression converter and then saw Russell's comment about converting sparkExpression to sparkFilter and then to IcebergExpression. I couldn't find a way to do that. So, I should go back to testing sparkExpression or do we have a way to achieve it ? b) About avoiding manual parser for sort order, I tried `SqlBaseParser::orderedIdentifierList`, it gave empty results. Didn't work. I will explore more on this. Other than these two, everything else is handled. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
