rdblue commented on pull request #3565: URL: https://github.com/apache/iceberg/pull/3565#issuecomment-971834899
I agree that string manipulation is probably more expensive than the select, but I'm not too concerned about this. That said, the complexity here looks reasonable since it is just passing a set of IDs to `select`. I could go either way. +1 if you want to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
