ajantha-bhat edited a comment on pull request #3375: URL: https://github.com/apache/iceberg/pull/3375#issuecomment-972672239
@RussellSpitzer : Regarding the last problem remaining; About not using the custom parser for sort-order parsing, the `RewriteDataFilesProcedure` is in `iceberg-spark-3.2` module. So, I cannot refer or cast to `IcebergSparkSqlExtensionsParser` there as it will add a circular dependency[1] on `iceberg-spark-3.2-extensions` module. So, I have to use only the default spark parser functionality. Cannot use new functionalities of Iceberg parser. **So, do we have a solution for this? If not, can we go with the current code as of now? Other than this change, everything else is addressed.** [1] To avoid above mentioned circular dependency, I just thought of moving `RewriteDataFilesProcedure` to spark-extensions. But `ProcedureBuilder` in spark-3.2 again has to depend on spark-3.2-extensions which leads to circular dependency. So, I tried moving whole `Procedure` package to spark-3.2-extensions. But then `BaseCatalog` in spark-3.2 again has to depend on spark-3.2-extensions which leads to circular dependency. As we can't move everything to spark-extensions I stopped there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
