rdblue commented on a change in pull request #3553:
URL: https://github.com/apache/iceberg/pull/3553#discussion_r752441209
##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/AliyunProperties.java
##########
@@ -25,21 +25,74 @@
import org.apache.iceberg.util.PropertyUtil;
public class AliyunProperties implements Serializable {
+ /**
+ * The domain name used to access OSS. OSS uses HTTP Restful APIs to provide
services. Different regions are accessed
+ * by using different endpoints. For the same region, access over the
internal network or over the Internet also uses
+ * different endpoints. For more information, see:
+ * https://www.alibabacloud.com/help/doc-detail/31837.htm
+ */
+ public static final String OSS_ENDPOINT = "oss.endpoint";
+
+ /**
+ * Aliyun uses an AccessKey pair, which includes an AccessKey ID and an
AccessKey secret to implement symmetric
+ * encryption and verify the identity of a requester. The AccessKey ID is
used to identify a user.
+ * <p>
+ * For more information about how to obtain an AccessKey pair, see:
+ * https://www.alibabacloud.com/help/doc-detail/53045.htm
+ */
+ public static final String ACCESS_KEY_ID = "access.key.id";
+
+ /**
+ * Aliyun uses an AccessKey pair, which includes an AccessKey ID and an
AccessKey secret to implement symmetric
+ * encryption and verify the identity of a requester. The AccessKey secret
is used to encrypt and verify the
+ * signature string.
+ * <p>
+ * For more information about how to obtain an AccessKey pair, see:
+ * https://www.alibabacloud.com/help/doc-detail/53045.htm
+ */
+ public static final String ACCESS_KEY_SECRET = "access.key.secret";
Review comment:
It's fine to keep them if we think it will break people, but in the
future we should be careful. Being lax about naming leads to poor user
experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
