rymurr commented on pull request #3579: URL: https://github.com/apache/iceberg/pull/3579#issuecomment-974163688
> @rymurr : This looks like a right direction to me. But I have some doubts. a) How user can register their procedures without extending base catalog ? Now looks like still we need to extend catalog to gain access to these methods. thats correct. This isn't a great approach at the moment. We could make the method I added `static` or take one of the approaches I outlined above. Definitely interested in where other people think it could go. > > b) And regarding disable of existing procedures, we have not removed look up `SparkProcedures.newBuilder(name)` in the PR, so I would assume we need to disable by adding dummy procedure for them. Is my assumption is correct ? yes by adding a `null` to the new map we could 'override' an existing procedure. Again, not the cleanest thing int he world but it requires access to the immutable static map if we want to remove a procedure properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
