rdblue commented on pull request #3578: URL: https://github.com/apache/iceberg/pull/3578#issuecomment-974316978
I don't think that this change is correct because Iceberg expressions do not implement SQL 3-value boolean logic. Iceberg expressions avoid SQL logic because it is really confusing and hard to maintain correctly. The API is also not only used in SQL and we need to have reasonable behavior for all callers. SQL systems should handle null semantics when converting to Iceberg expressions -- that's why we don't allow null literals. (One thing that we've discussed in the past is adding special SQL factory methods that help with this, which may be a good idea.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
