kbendick commented on a change in pull request #3573:
URL: https://github.com/apache/iceberg/pull/3573#discussion_r751995960
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestNamespaceSQL.java
##########
@@ -100,12 +99,96 @@ public void testDropNonEmptyNamespace() {
Assert.assertTrue("Table should exist",
validationCatalog.tableExists(TableIdentifier.of(NS, "table")));
AssertHelpers.assertThrows("Should fail if trying to delete a non-empty
namespace",
- SparkException.class, "non-empty namespace",
+ Exception.class, "empty",
Review comment:
So this is the exception that the spak_catalog and hadoop_catalog throw.
The only one that changed is HiveCatalog, because our HMS client reports the
exception. There's existing code to throw the exception it gives as
`NoSuchNamepace` exception, but it needs to be updated now.
But this would work for 2/3 of those still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
