rdblue commented on a change in pull request #3567:
URL: https://github.com/apache/iceberg/pull/3567#discussion_r753852357



##########
File path: 
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestNewRewriteDataFilesAction.java
##########
@@ -1054,6 +1045,41 @@ private void writeDF(Dataset<Row> df) {
         .save(tableLocation);
   }
 
+  private List<DeleteFile> writePosDeletesToFile(Table table, DataFile 
dataFile,
+                                                 int outputDeleteFiles, int 
rowsPerDelete) {

Review comment:
       rowsPerDeleteFile is always 1? Can we remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to