rdblue commented on a change in pull request #3592:
URL: https://github.com/apache/iceberg/pull/3592#discussion_r753871444
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadataParser.java
##########
@@ -253,8 +254,42 @@ public static TableMetadata read(FileIO io, InputFile
file) {
}
}
- @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ /**
+ * Read TableMetadata from a JSON string.
+ * <p>
+ * The TableMetadata's metadata file location will be unset.
+ *
+ * @param io a FileIO used by {@link Snapshot} instances
+ * @param json a JSON string of table metadata
+ * @return a TableMetadata object
+ */
+ public static TableMetadata fromJson(FileIO io, String json) {
Review comment:
I went to add the Snapshot changes and they're actually smaller than I
thought so I'll add them in this PR. I still think it's a good idea to require
`FileIO` in the method because we want most people to always pass one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
