ajantha-bhat commented on a change in pull request #3589:
URL: https://github.com/apache/iceberg/pull/3589#discussion_r753939749
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/DeleteOrphanFilesProcedure.java
##########
@@ -37,11 +37,11 @@
import org.apache.spark.unsafe.types.UTF8String;
/**
- * A procedure that removes orphan files in a table.
+ * A procedure that deletes orphan files in a table.
*
* @see SparkActions#deleteOrphanFiles(Table)
*/
-public class RemoveOrphanFilesProcedure extends BaseProcedure {
+public class DeleteOrphanFilesProcedure extends BaseProcedure {
Review comment:
Agree.
But I thought it is better to make Action name and procedure name same, so
that user will not get confused.
Even though it is breaking change we can add it in the release notes and
notify users ?
@rdblue , @RussellSpitzer : If you still think it is ok to have different
names for procedure and Action, I can revert this. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
