jackye1995 commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r754640566
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -717,6 +717,19 @@ public TableMetadata removeSnapshotLogEntries(Set<Long>
snapshotIds) {
snapshots, newSnapshotLog, addPreviousFile(file, lastUpdatedMillis));
}
+ public TableMetadata withUpdatedSnapshotAndSchema(long snapshotId, int
schemaId, int sortOrderId, int specId) {
Review comment:
For #2957 I was waiting for more clarity around the REST catalog to
design the table metadata update builder semantics, so it probably won't be
merged very soon. But I agree with Ryan that this seems like a very restrictive
method, and the intention of the operation is unclear comparing to the other
update methods (although I know how it fits in the Nessie context).
To update the schemaId, sortOrderId, specId to a specific version, I think
it makes more sense to expose specific APIs in related update classes instead
of having everything done through a separated method. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
