pvary commented on a change in pull request #3591: URL: https://github.com/apache/iceberg/pull/3591#discussion_r754842116
########## File path: CONTRIBUTING.md ########## @@ -45,4 +45,67 @@ on how to build iceberg locally. For Java styling, check out the section [Setting up IDE and Code Style](https://iceberg.apache.org/community/#setting-up-ide-and-code-style) from the -documentation site. For Python, please use the tox command `tox -e format` to apply autoformatting to the project. +documentation site. + +For Python, please use the tox command `tox -e format` to apply autoformatting to the project. + +### Java style guidelines + +#### Line breaks + +Continuation indents are 2 indents (= 4 spaces) from the start of the previous line. + +Try to break long lines at the same semantic level to make code more readable. +* Don't use the same level of indentation for arguments to different methods Review comment: Shall we add some chained methods to the example as well? Or when this will be displayed on the site, it will be easier to see the connection between the example and the code? Github view doesn't really help here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
