rdblue commented on a change in pull request #3597:
URL: https://github.com/apache/iceberg/pull/3597#discussion_r755614832
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -647,7 +647,7 @@ private static void deleteManifests(FileIO io,
List<ManifestFile> manifests) {
private final String format;
public SparkPartition(Map<String, String> values, String uri, String
format) {
- this.values = ImmutableMap.copyOf(values);
+ this.values = new HashMap<>(values);
Review comment:
Can you use `Maps.newHashMap`? We prefer the Guava factory methods to
individual implementations.
Also, can you add a test for this that does a round-trip serialization using
Kryo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
