jackye1995 commented on pull request #3425: URL: https://github.com/apache/iceberg/pull/3425#issuecomment-978313699
@rdblue thanks for the detailed review, I have made the following changes: 1. `refs` is changed to a map type given the fact that all reference names must be unique in the table 2. `max-ref-age-ms` is added 3. `current-branch` is removed 2. I removed the `snapshot tagging and branching` page for now to make this more focused on the spec change, and moved retention policy into the spec. I will continue to edit the page based on your suggestions, but I think it's better to have that published after the `UpdateSnapshotReference` API is implemented, so we can also provide code snippets for the specific use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
