kbendick commented on pull request #3326: URL: https://github.com/apache/iceberg/pull/3326#issuecomment-980438934
> Hey @harshm-dev personally I am +0 on this change. I think it would be really good to rationalise the `type` and `catalog-*` parameters and this does so. I am not sure how other people are using these fields and if its disruptive or not. What do others think? I'm +0 and as stated would like to do a deeper look across all engines on how configs are provided and needed. I know for example my knowledge in Hive on Tez / map-reduce (classic Hive) is limited. One thing that breaking out enums or additional interfaces might help with is adding the ability to instantiate catalogs in situations where user's don't have `Configuration` on their classpath (e.g. with some Flink environments as one example). Right now `catalog-impl` has a dependency on `Configurable` but in some cases that's not necessary (per user reports). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
