aokolnychyi commented on a change in pull request #3613:
URL: https://github.com/apache/iceberg/pull/3613#discussion_r757705197
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -168,9 +169,23 @@ public static Expression convert(Filter filter) {
case NOT:
Not notFilter = (Not) filter;
- Expression child = convert(notFilter.child());
- if (child != null) {
- return not(child);
+ Filter childFilter = notFilter.child();
Review comment:
We could try to implement `rewriteNot` for Spark filters but that sounds
like a lot of work for such a small use case. We will have to create a custom
`NotIn` Spark filter, a visitor to traverse Spark filters, a negation mapping,
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
