zhongyujiang commented on pull request #3605: URL: https://github.com/apache/iceberg/pull/3605#issuecomment-980645315
Hi @chenjunjiedada, I found that [RemoveIds](https://github.com/apache/iceberg/blob/master/parquet/src/main/java/org/apache/iceberg/parquet/RemoveIds.java#L50) haven't keep the original name of repeatedElement of list/map type too: ``` @Override public Type list(GroupType array, Type item) { return Types.list(array.getRepetition()) .element(item) .named(array.getName()); } ``` I think this also need a fix. And speaking of unit test, I found that [TestPruneColumns](https://github.com/apache/iceberg/blob/master/parquet/src/test/java/org/apache/iceberg/parquet/TestPruneColumns.java) already did a similar one for PruneColumns, maybe I can reuse the fileSchema in it, so can I just rename TestPruneColumns to TestParquetTypeVisitor and put the unit tests for RemoveIds and ApplyNameMapping in it? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
