rdblue commented on a change in pull request #3425:
URL: https://github.com/apache/iceberg/pull/3425#discussion_r758797725



##########
File path: site/docs/spec.md
##########
@@ -566,6 +566,38 @@ Notes:
 1. An alternative, *strict projection*, creates a partition predicate that 
will match a file if all of the rows in the file must match the scan predicate. 
These projections are used to calculate the residual predicates for each file 
in a scan.
 2. For example, if `file_a` has rows with `id` between 1 and 10 and a delete 
file contains rows with `id` between 1 and 4, a scan for `id = 9` may ignore 
the delete file because none of the deletes can match a row that will be 
selected.
 
+#### Snapshot Reference
+
+Iceberg tables keep track of branches and tags using snapshot references. 
+Tags are labels for individual snapshots. Branches are mutable named 
references that can be updated by committing a new snapshot as the branch's 
referenced snapshot using the [Commit Conflict Resolution and 
Retry](#commit-conflict-resolution-and-retry) procedures.
+
+The snapshot reference object records all the information of a reference 
including snapshot ID, reference type and [Snapshot Retention 
Policy](#snapshot-retention-policy).
+

Review comment:
       I'd be fine either way. I think that the advantage here is that it is 
simple to express. Having a list of expiration policies and applying them 
selectively to tags or branches, possibly by identifying the policy by ID seems 
a bit overkill to me. I think you'd probably have some default branch/tag 
retention, retention for branch versions, and that's it. Even customizing that 
per branch seems a little speculative to me. I think people will likely just 
set expiration globally and forget about it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to