kbendick commented on a change in pull request #3627:
URL: https://github.com/apache/iceberg/pull/3627#discussion_r759714220
##########
File path: spark/v3.1/build.gradle
##########
@@ -130,12 +130,12 @@ project(":iceberg-spark:iceberg-spark-3.1-extensions") {
compileOnly project(':iceberg-orc')
compileOnly project(':iceberg-common')
compileOnly project(':iceberg-spark:iceberg-spark-3.1')
- compileOnly project(':iceberg-hive-metastore')
compileOnly("org.apache.spark:spark-hive_2.12:${sparkVersion}") {
exclude group: 'org.apache.avro', module: 'avro'
exclude group: 'org.apache.arrow'
}
+ testImplementation project(path: ':iceberg-hive-metastore')
testImplementation project(path: ':iceberg-hive-metastore', configuration:
'testArtifacts')
Review comment:
Question: It looks like this line is duplicated, but the second one has
`configuration: 'testArtifacts'`.
Can we use just one or the other? This occurs in a few places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
