rdblue commented on a change in pull request #3640:
URL: https://github.com/apache/iceberg/pull/3640#discussion_r761496896
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -125,6 +127,16 @@ public ThisT set(String property, String value) {
return self();
}
+ protected void caseSensitiveBinding(boolean newCaseSensitive) {
+ this.caseSensitive = newCaseSensitive;
+ filterManager.caseSensitive(newCaseSensitive);
+ deleteFilterManager.caseSensitive(newCaseSensitive);
+ }
+
+ protected boolean caseSensitive() {
Review comment:
I think this should be `isCaseSensitive`. I think we mostly use the `is`
prefix for returning booleans like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
