jackye1995 commented on a change in pull request #3375: URL: https://github.com/apache/iceberg/pull/3375#discussion_r761613123
########## File path: spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java ########## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.extensions; + +import java.util.List; +import java.util.Map; +import java.util.stream.IntStream; +import org.apache.iceberg.AssertHelpers; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.spark.sql.AnalysisException; +import org.apache.spark.sql.catalyst.analysis.NoSuchProcedureException; +import org.junit.After; +import org.junit.Test; + + +public class TestRewriteDataFilesProcedure extends SparkExtensionsTestBase { + + public TestRewriteDataFilesProcedure(String catalogName, String implementation, Map<String, String> config) { + super(catalogName, implementation, config); + } + + @After + public void removeTable() { + sql("DROP TABLE IF EXISTS %s", tableName); + } + + @Test + public void testRewriteDataFilesInEmptyTable() { + createTable(); + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files('%s')", catalogName, tableIdent); + assertEquals("Procedure output must match", + ImmutableList.of(row(0, 0)), + output); + } + + @Test + public void testRewriteDataFilesOnPartitionTable() { + createPartitionTable(); + // create 5 files for each partition (data = 'foo' and data = 'bar') + insertData(5); + List<Object[]> expectedRecords = currentData(); + + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files(table => '%s')", catalogName, tableIdent); + + assertEquals("Action should rewrite 10 data files and add 2 data files (one per partition) ", + ImmutableList.of(row(10, 2)), + output); + + List<Object[]> actualRecords = currentData(); + assertEquals("data should match", expectedRecords, actualRecords); + } + + @Test + public void testRewriteDataFilesOnNonPartitionTable() { + createTable(); + // create 10 files under non-partitioned table + insertData(5); + List<Object[]> expectedRecords = currentData(); + + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files(table => '%s')", catalogName, tableIdent); + + assertEquals("Action should rewrite 10 data files and add 1 data files", + ImmutableList.of(row(10, 1)), + output); + + List<Object[]> actualRecords = currentData(); + assertEquals("data should match", expectedRecords, actualRecords); Review comment: nit: "Data after compaction should not change" ########## File path: spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java ########## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.extensions; + +import java.util.List; +import java.util.Map; +import java.util.stream.IntStream; +import org.apache.iceberg.AssertHelpers; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.spark.sql.AnalysisException; +import org.apache.spark.sql.catalyst.analysis.NoSuchProcedureException; +import org.junit.After; +import org.junit.Test; + + +public class TestRewriteDataFilesProcedure extends SparkExtensionsTestBase { + + public TestRewriteDataFilesProcedure(String catalogName, String implementation, Map<String, String> config) { + super(catalogName, implementation, config); + } + + @After + public void removeTable() { + sql("DROP TABLE IF EXISTS %s", tableName); + } + + @Test + public void testRewriteDataFilesInEmptyTable() { + createTable(); + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files('%s')", catalogName, tableIdent); + assertEquals("Procedure output must match", + ImmutableList.of(row(0, 0)), + output); + } + + @Test + public void testRewriteDataFilesOnPartitionTable() { + createPartitionTable(); + // create 5 files for each partition (data = 'foo' and data = 'bar') + insertData(5); + List<Object[]> expectedRecords = currentData(); + + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files(table => '%s')", catalogName, tableIdent); + + assertEquals("Action should rewrite 10 data files and add 2 data files (one per partition) ", + ImmutableList.of(row(10, 2)), + output); + + List<Object[]> actualRecords = currentData(); + assertEquals("data should match", expectedRecords, actualRecords); + } + + @Test + public void testRewriteDataFilesOnNonPartitionTable() { + createTable(); + // create 10 files under non-partitioned table + insertData(5); + List<Object[]> expectedRecords = currentData(); + + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files(table => '%s')", catalogName, tableIdent); + + assertEquals("Action should rewrite 10 data files and add 1 data files", + ImmutableList.of(row(10, 1)), + output); + + List<Object[]> actualRecords = currentData(); + assertEquals("data should match", expectedRecords, actualRecords); + } + + @Test + public void testRewriteDataFilesWithOptions() { + createTable(); + // create 2 files under non-partitioned table + insertData(1); + List<Object[]> expectedRecords = currentData(); + + // set the min-input-files = 2, instead of default 5 to allow compaction + List<Object[]> output = sql( + "CALL %s.system.rewrite_data_files(table => '%s', options => map('min-input-files','2'))", + catalogName, tableIdent); + + assertEquals("Action should rewrite 2 data files and add 1 data files", + ImmutableList.of(row(2, 1)), + output); + + List<Object[]> actualRecords = currentData(); + assertEquals("data should match", expectedRecords, actualRecords); Review comment: nit: "Data after compaction should not change" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
