jackye1995 opened a new pull request #3659:
URL: https://github.com/apache/iceberg/pull/3659
@openinx @xingbowu
I was writing #3658 and I noticed that there is some inconsistency between
Aliyun and AWS module. I suggest making the following changes:
1. use `client.access-key-id` and `client.secret-access-key` as property
names,
`.` is used to build hierarchy to config name, but `access.key.id` does not
have any hierarchy in it. Also I checked Aliyun doc, the name is secret access
key, not access key secret, as shown in the builder method:
```
public class OSSClientBuilder implements OSSBuilder {
@Override
public OSS build(String endpoint, String accessKeyId, String
secretAccessKey) {
return new OSSClient(endpoint,
getDefaultCredentialProvider(accessKeyId, secretAccessKey),
getClientConfiguration());
}
```
I made `client` as the prefix because it seems like your credentials config
will affect all the clients. In AWS module, I made the config
`s3.access-key-id` because it would only affect `s3`.
2. I renamed `AliyunClientFactories.load` to `AliyunClientFactories.from` to
be consistent with `AwsClientFactories.from`. It also seems to me that the
default client did not initialize and load the properties, so I also fixed the
method and added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
