kbendick commented on issue #3393: URL: https://github.com/apache/iceberg/issues/3393#issuecomment-985746506
> TBH, this fix is a really interesting story: > > * No Iceberg change is needed - this is clearly a Hive issue. > * In Hive master we are phasing out MR, and only Tez is supported (the issue does not happen with Tez) > * Even the tests are lame for the fix as we need to insert the data with Tez (MR is not supported with Iceberg), but the query should be run with MR to find the issue. > * To be correctly backported the change should be rebased to Hive branch-2.3, branch-2, branch-3 and branch 3.1. The issue is that the tests will not work for these branches as Iceberg is not supported there. > > I have serious number of other tasks. I have found the issue and put the solution upstream, so if someone faces this they can fix it, but sadly I did not have time to follow up with a solution which could be released. I hope the affected ones will find it here, and if someone has time to backport the fixes, I am happy to review and push. > > Thanks, Peter Thanks for the deep dive @pvary! I think it’s fair to leave as is, and if somebody is really affected they can pick up the issue or apply the necessary patch in their fork. This also begs the question: should we be running MR in the unit tests in this repo? How many users are using MR vs Tez for the limited amount of functionality that is supported? It’s also good to remove from the 0.13.0 milestone, as there’s nothing we can do about it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
