kbendick commented on pull request #3645: URL: https://github.com/apache/iceberg/pull/3645#issuecomment-986175692
> @kbendick that RewriteProcedure is for the SQL Version only, so the above error is probably something else. I'll check it out on monday. > > The Action itself just uses standard "Iceberg" Expressions in the filter clause. Oh good point. You’re right. I spent some time playing around with it and I actually couldn't get it to error out, though I very much could have been doing something wrong on my end. Since we'd have to fix it with Flink as well, and I have a note from Ryan in an old PR that toString might eventually not be the best choice because it's possibly a CharSequence and possibly null, it might make the most sense to just inline the check ourselves. I'll talk to you more on Monday. Again, thank you @hbgstc123 for reporting this and providing a fix, and your PR would likely fix the problem, we just need to be sure we're fixing it in the most appropriate place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
