kbendick commented on pull request #3543: URL: https://github.com/apache/iceberg/pull/3543#issuecomment-986410357
> Just to resonate with what Russell said, I have also heard a few customers got confused about the caching behaviors, and not enabling caching directly would likely be a more straight-forward solution for users, compared to have a 30 seconds expiration that we have to then explain potential behaviors of query based on this expiration time. > > Overall I think it's worth adding the feature, Trino and Presto also has something similar like `hive.metastore-refresh-interval`. I would personally just do not set a default for that config, given it is an optional config anyway. > > Given the fact that the PR is also getting quite messy with all the changes, I would say let's first add the `cache-enabled` as a catalog property with `true` as default, which is the default behavior today. Then we can add time-based expiration and review it separately in more details. Oh I better understand what you're saying now. I'll split this into two PRs, one that makes it an optional opt-in (all current behavior the same), like Spark is. And just add the behavioral change. And then a follow-up to plumb that through and we can turn it on there (or not). Will let you know when the new PR is up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
