openinx commented on a change in pull request #3270:
URL: https://github.com/apache/iceberg/pull/3270#discussion_r762807102
##########
File path: build.gradle
##########
@@ -285,9 +285,16 @@ project(':iceberg-aliyun') {
implementation project(':iceberg-common')
compileOnly 'com.aliyun.oss:aliyun-sdk-oss'
Review comment:
If we plan to add this into bundled `aliyun-iceberg` jar, then this
line should use `implementation` rather than `compileOnly`. Because we only
add classes from `implementation` jars when packaging the whole iceberg jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
