mayursrivastava commented on pull request #3294: URL: https://github.com/apache/iceberg/pull/3294#issuecomment-986874859
(apologies for the delay, due to year-end stuff, I wasn't able to get back to this pr). I've made the following updates: 1. Refactored ```InMemoryCatalog``` code so that ```InMemoryTableOperations``` is as inner class and both directly access namespace/table maps. 2. Refactored ```InMemoryFileIO``` such all other classes are inner classes and all of them directly access the ```InMemoryFileStore```. 3. Added seek test to ```InMemoryFileIOTest``` to better emulate parquet file read behavior. 4. Moved common catalog tests from ```TestHadoopCatalog``` to ```CommonCatalogTests```. The ```CommonCatalogTests``` runs parameterized tests on ```HadoopCatalog``` and ```InMemoryCatalog```. ```CommonCatalogTests``` contains tests that don't require checking the file system (as was done by a few tests in the ```TestHadoopCatalog```). This change was made so that we run the same tests on the ```InMemoryCatalog``` as done by other catalogs. 5. Rebased/resolved conflicts from ```TestHadoopCatalog```. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
